[ 
https://issues.jboss.org/browse/WELD-949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ondrej Zizka updated WELD-949:
------------------------------

    Description: 
I suggest to move firing of ContainerInitialized event from StartMain to the 
end of Weld.initialize().

Rationale:

 * Having this done by Weld.initialize() is more expectable (IMO) than having 
it restricted to a concrete class.
 * With the event fired from the end of initialize(), users who bootstrap Weld 
on their own would not need to introduce their own "startup", or worse, fire 
ContainerInitialized on their own.
 * Backward compatible - currently only StartMain() fires the event. In case of 
this change, firing would be removed from StartMain(), so the current behavior 
would not change. The only case when it would do harm is if user fired 
ContainerInitialized in their own code. Which they should not - such usage 
smells :)



  was:
I suggest to move firing of ContainerInitialized event from StartMain to the 
end of Weld.initialize().

Rationale:

 * Having this done by Weld.initialize() is more expectable() than having it 
restricted to a concrete class.
 * With the event fired from the end of initialize(), users who bootstrap Weld 
on their own would not need to introduce their own "startup", or worse, fire 
ContainerInitialized on their own.
 * Backward compatible - currently only StartMain() fires the event. In case of 
this change, firing would be removed from StartMain(), so the current behavior 
would not change.





> Move firing of ContainerInitialized event from StartMain to the end of 
> Weld.initialize()
> ----------------------------------------------------------------------------------------
>
>                 Key: WELD-949
>                 URL: https://issues.jboss.org/browse/WELD-949
>             Project: Weld
>          Issue Type: Feature Request
>          Components: Java SE Support
>    Affects Versions: 1.1.1.Final
>            Reporter: Ondrej Zizka
>            Priority: Optional
>
> I suggest to move firing of ContainerInitialized event from StartMain to the 
> end of Weld.initialize().
> Rationale:
>  * Having this done by Weld.initialize() is more expectable (IMO) than having 
> it restricted to a concrete class.
>  * With the event fired from the end of initialize(), users who bootstrap 
> Weld on their own would not need to introduce their own "startup", or worse, 
> fire ContainerInitialized on their own.
>  * Backward compatible - currently only StartMain() fires the event. In case 
> of this change, firing would be removed from StartMain(), so the current 
> behavior would not change. The only case when it would do harm is if user 
> fired ContainerInitialized in their own code. Which they should not - such 
> usage smells :)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
_______________________________________________
weld-issues mailing list
[email protected]
https://lists.jboss.org/mailman/listinfo/weld-issues

Reply via email to