[weld-issues] [JBoss JIRA] (WELD-2031) Jetty Decorator use is wrong (documentation and code)

[Joakim Erdfelt (JIRA)]

Title: Message Title

Joakim Erdfelt commented on WELD-2031   Re: Jetty Decorator use is wrong (documentation and code) That updated doc is wrong as well. The doctype is wrong, it should be the following for Jetty 9.0 thru 9.2 <!DOCTYPE Configure PUBLIC "-//Jetty//Configure//EN" "http://www.eclipse.org/jetty/configure_9_0.dtd"> and this for Jetty 9.3 <!DOCTYPE Configure PUBLIC "-//Jetty//Configure//EN" "http://www.eclipse.org/jetty/configure_9_3.dtd"> The "prependServerClass" method has never supported comma delimited classnames. So the xml should look like this ... <Configure class="org.eclipse.jetty.webapp.WebAppContext"> <Set name="contextPath">/weld-numberguess</Set> <Set name="war"><Property name="jetty.webapps" default="."/>/weld-numberguess.war</Set> <Call name="prependServerClass"> <Arg>-org.eclipse.jetty.server.handler.ContextHandler</Arg> </Call> <Call name="prependServerClass"> <Arg>-org.eclipse.jetty.servlet.FilterHolder</Arg> </Call> <Call name="prependServerClass"> <Arg>-org.eclipse.jetty.servlet.ServletContextHandler</Arg> </Call> <Call name="prependServerClass"> <Arg>-org.eclipse.jetty.servlet.ServletHolder</Arg> </Call> </Configure> But even this is ultimately incorrect as it doesn't take into account the differences between Jetty 9.0 and 9.3 (which is big, as that represents 4 major releases of Jetty) Reminder: Jetty versioning is (and always has been) "ServletSpec.MajorVersion.MinorVersion". 9.0 is the first major release to support Servlet 3.1 (and even then they were draft versions of Servlet 3.1 spec) 9.1 being another major release version to (now) support servlet 3.1 final (and refactored websocket) 9.2 being another major release version to support servlet 3.1 (and now JSR356) 9.3 is another major release (adding HTTP/2 & ALPN, dropping older HTTP specs, updating HTTP behavior for new/updated/obsoleted RFCS, vastly updated clients, new Proxy layers, along with more refactoring). Add Comment   This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4)

_______________________________________________
weld-issues mailing list
weld-issues@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/weld-issues