Hello,
Jean-Philippe Barrette-LaPierre a écrit :
Hi, My name is Jean-Philippe Barrette-LaPierre and I'm a main programmer for
SFLPhone.
Congratulations for your work, it's a very nice piece of software!
Last month I wanted to add skins to SFLPhone.
Is the screenshot available on your homepage the result of this effort?
It looks pretty good.
I looked at your
project to see how you handle this. It gave me a very good idea of the
concepts. I checked if I could use your library as the skin manager, but I
decided not to. Here's the reason:
The way your library is made, you have a skin "builder" (using the name from
the design pattern) that's responsible of skinning a widget. The problem is
that the dispaching of "skinners" is hardcoded within a single function. This
behavior just forbid any developper to had a skin to an user-made widget. So,
I decided to code my own library (taxidermist) to handle skinning of widgets.
Mostly, I used your way of skinning widgets, but with a different way of
dispatching the "skinners".
Thank you for your comments. I don't know very much about our current
skin system's implementation, so i can't tell that much about its
shortcomings. Another developer may better discuss this issue.
I wonder if we could merge the projects (skin library). You can check what
I've done in the sflphone CVS, under the directory /src/libs/taxidermy. check
here: http://sflphone.org/cvs.html for CVS instructions.
We could use IRC to discuss more further the implications of that. We have a
channel on freenode (#sflphone)
Cool! We'll have a look at the code, and i'm already on #sflphone ;-)!
Thank you very much for your suggestions!
All the best,
--
Julien Gilli
OpenWengo, the free and multiplatform VoIP client
http://dev.openwengo.com/
_______________________________________________
Wengophone-devel mailing list
[email protected]
http://dev.openwengo.com/mailman/listinfo/wengophone-devel
