Darshaka Pathirana wrote: > Hi! > Hello,
> - How to create the patch?
svn diff file > foo.patch
if you fix a bug in N source files of a module use.
svn diff file..fileN > foo.patch
Don't submit everything as one big patch.
> - What should be the filename of the patch?
I name them after the subject.
fix_gcc43_warnings.patch for example
> - How is the patch submitted?
>
Attach them to a bug or add them as an attachement to an email.
> The first question should be easy to answer:
>
> - Use "svn diff" or create a patch with TortoiseSVN (or even use "diff
> -u")
>
> The second question is not that easy. My suggestion (if anybody
> cares):
>
> - {OrigFilename}_r{svnrevision}_{patchName}-{patchVersion}.diff|patch
>
> The third question is also not as easy as it seems:
>
> As Attachment?
attachement
>
> What should be the subject?
>
> [PATCH] - {OrigFilename}_r{svnrevision}_{patchName}-{patchVersion}
[PATCH] - Subject of the patch
Git has a special approach for commit messages, I think it is the same for hg.
The first line is a summary of the patch, max 60 chars. Then an empty line and
a description of the patch.
>
> I also like the idea of [3] of adding a patch header on each patch,
> but I may be wrong.
>
Yes, this makes it easier for the reviewer. I do that normally. With git you do
git-format-patch origin/master
and you get what you want. I hope hg can do the same.
> What do you maintainer and longtime contributors think? Is that too
> much overkill or would you like to stick to some guidelines? I would
> love to hear your opinions. Thank you!
>
git does everything which you asked for. Hopefully hg behaves the same. The
important thing is that you write good commit messages.
> Greetings,
> - Darsha
-- andreas
--
http://www.cynapses.org/ - cybernetic synapses
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Wengophone-devel mailing list [email protected] http://dev.openwengo.com/mailman/listinfo/wengophone-devel
