Darshaka Pathirana wrote:
On 27.02.2008 16:50, Vadim Lebedev wrote:
Darshaka Pathirana wrote:
As I still have no good solution on passing the mercurial revision
to the code when building with Visual Studio 2005 it is important to
have a workaround 'cause without the patch the code stays
uncompilable.

My workaround sets the revision to 0 if the compiler is VC++.

A better solution I can think of is to read a external file (like
#include <hg_revision.h>) which is generated by an
cmake-pre-build-process.  Maybe somebody knows how to do that as my
knowledge on CMake is merely humble.

Actually it works perfectly well the SVN_VERSION variable holds
merucrial rev hash now

Yes. The mercurial-revision is in the SVN_VERSION variable. That
works fine. But the actual problem is that the Visual C++ compiler
can not handle quotes with the "-D" option. So we have to think of
something else to pass the revision into the code.


My wengophone generates correct value in UserAgent filed in sip
requests... So the things works correctly here

Strange. I just recompiled wengophone with your latest revision and
the version string is shown fine in the About-Dialogbox. I have to
say, that I had my patch applied and expected to see a rev0 but saw
this: "WengoPhone 2.2 reva58d652beefd-20080226111836".

But this is actually also not correct because if I do:
C:\Projects\wp-2.2_hg>hg tip
changeset:   76:8ab95df2e80b
tag:         tip
user:        Darshaka Pathirana <[EMAIL PROTECTED]>
date:        Wed Feb 27 16:14:44 2008 +0100

So date and revision are not that what one would expect. Maybe you
can help me and tell where to look at to get the right information
(mainly because my patch handles phapi, so I am not sure if that has
anything to do with the string in the aboutbox)

By the way: as mecurial has a alpha-numeric revision wouldn't it be
better to add a delimiter between "rev" and the revision (like
rev_a58d652beefd)?

Greetings,
 - Darsha
_______________________________________________
Wengophone-devel mailing list
[email protected]
http://dev.openwengo.com/mailman/listinfo/wengophone-devel


Darshaka, be assured i don't think you're dumb (but this happens to best of us) :)
Are you sure you did /hg update/ after /hg pull/?

And i'm curious did you build using build.sh or using make?

Thanks
Vadim
_______________________________________________
Wengophone-devel mailing list
[email protected]
http://dev.openwengo.com/mailman/listinfo/wengophone-devel

Reply via email to