Follow-up Comment #1, patch #911 (project wesnoth):
Quite some nice cleanups but also indeed some things that need discussion.
Also your svn tree is in state of conflict so the patch can't be applied.
Here some comment I already posted on IRC as well.
your std::sqrt change in sound_sources looks odd, one place it's used the
next on the same line not
also the inclusion of math.h with already a cmath also looks odd, Makefile.am
has a conflict
server.cpp also
your changes to configure.ac break debug builds and the changing of the
default flags also seems a bad idea.
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?911>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
