Update of patch #1028 (project wesnoth):
Status: None => In Progress
Assigned to: None => boucman
_______________________________________________________
Follow-up Comment #8:
* please add a changelog entry
* please add yourself in the data/core/about.cfg
ok, now let's look at the code
* there is a call in main() to generate map in mapgen.cpp
looking at the program i'm not sure we should wrap it, but I'm mentionning
anyway
however I have a deeper design concern wrt this patch...
when map generation fails, we return an empty map which makes sense...
you change that to raising an exception... we try to avoid exceptions as much
as we can in wesnoth, but that makes sense too...
however all your catch block then return a meaningless string (a text string
instead of a map, or just a space) which doesn't make sense...
no. the API (returning empty if map generation was incorrect) makes more
sense, please keep that. The problem is not in map generation. The bug is in
the caller not checking if the map is an empty map. Please correct at that
level (adding some logging in the map generation code makes sense,
though...)
thx for looking into that, I'm looking forward to your next iteration
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?1028>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
