Update of patch #951 (project wesnoth):
Status: None => Wont Do
_______________________________________________________
Follow-up Comment #3:
I don't see any reasonable rationale for this patch.
SDL_Surface already has its own reference counting system which 'surface'
uses and respects. If we convert to using boost::shared_ptr per the patch, we
will ignore the SDL_Surface reference count and use our own reference count.
Among other things, this is less efficient because the boost::shared_ptr
reference count allocates its own memory and is tracked separately. Whether
this would have any substantial impact on Wesnoth's performance is unclear,
but I see no reason to apply such a patch when surface is already
well-tested.
If anything, we would use boost::intrusive_ptr, since it is designed to work
with classes such as SDL_Surface which already have a reference count.
However, I see little reason to use boost::intrusive_ptr either, when surface
already works well and is well tested.
--David
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?951>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
