URL:
<http://gna.org/patch/?1090>
Summary: Mostly separate user_team_name from team_name
Project: Battle for Wesnoth
Submitted by: elvish_pillager
Submitted on: Wednesday 07/30/2008 at 13:03
Priority: 5 - Normal
Status: None
Privacy: Public
Assigned to: None
Originator Email:
Open/Closed: Open
Discussion Lock: Any
_______________________________________________________
Details:
The problem: when user_team_name isn't present in a [side], several places in
the code substitute team_name, though team_name isn't supposed to be visible
to the player (see Bug #9310, which is marked as fixed, though it doesn't
seem to be)
This patch removes most of that; In the status table, if there's no
user_team_name, it'll now display the string "Team {X}", where {X} is the
side number of the first side on that team. (Yes, in a 2vs2, you could end up
with Team 1 vs. Team 3. Mechanisms that make it always 1 vs 2 in that
situation seem to cause even more confusing team names in other situations.
If a scenario designer doesn't like the default names, well, they can go
ahead and add user_team_names (which they probably should be doing
anyway...))
It (the patch) also incidentally fixes a bug where setting user_team_name in
[modify_side] without also setting team_name would do nothing.
The only issue between team_name and user_team_name that I've found but not
corrected with this patch is on multiplayer_connect.cpp:1459 - I don't
understand that code well enough to confidently change it.
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: Wednesday 07/30/2008 at 13:03 Name: user_team_name_fix.diff Size: 3kB
By: elvish_pillager
<http://gna.org/patch/download.php?file_id=4645>
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?1090>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
