URL:
<http://gna.org/patch/?1112>
Summary: These are the parts of r29531 that had to be backed
out and I could not re-merge
Project: Battle for Wesnoth
Submitted by: esr
Submitted on: Sunday 11/09/2008 at 23:55
Priority: 5 - Normal
Status: None
Privacy: Public
Assigned to: suokko
Originator Email:
Open/Closed: Open
Discussion Lock: Any
_______________________________________________________
Details:
After soliton un-broke the AI (r30299), I made the effort required to pick
apart the AI changes by suokko that I had had to back out as an emergency fix
before 1.5.5.
I merged almost everything back in, with carefully commented small commits so
it can be reviewed by someone like Sirp of Soliton who really understands the
AI. Some of the merges put running code back in place; other esttore code
inside comments or #ifdefs so it can be reviewed in place. This patch is the
few dribs and drabs left that I couldn't merge sensibly or wasn't sure I
understood well enough to try.
suokko, if you ever read this, know that between the effort required to rip
out your broken code before 1.5.5 and what was required to merge all this
stuff back in, I have had to do about 18 hours of cleaning up after your
mess. I'm not too happy with you just now.
You did three things wrong. Any one of which would have been minor by itself
but the cumulative effect of all three was very bad.
1. You broke the AI in a subtle but serious way.
2. Your commits were huge, tangled messes. The divisions between them seemed
to be random, each one lumping together several unrelated changes. This made
reconstructing what you had done unreasonably difficult. And your commit
comments were not very helpful.
3. And then you disappeared. I had to go in and perform meatball surgery on
the AI code, not really knowing what I was doing, just so we could release
1.5.5.
If you ever re-materialize, I want to see smaller, finer-grained commits with
better explanations, otherwise I'm going to give you particular hell about bad
practice.
Eric S. Raymond <esr>
Project Member
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: Sunday 11/09/2008 at 23:55 Name: DIFF Size: 6kB By: esr
<http://gna.org/patch/download.php?file_id=4997>
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?1112>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
