Update of patch #1161 (project wesnoth):
Assigned to: None => mordante
_______________________________________________________
Follow-up Comment #1:
couple of comments :
* you miss a changelog entry
* no need for an about.cfg entry now, we already added you with your first
patch
more important :
you have a dual-purposed sorter : xp_sort is used both to sort by level and
by xp, I think this is a bad design. level sorting should be done using the
numeric_sorter, and I don't really see the point of having this sorter being
the only one with a double criterium (xp then level) where all the others
don't. Its a small break in UI design, and I don't think it's a good idea
I assign this patch to mordante for the moment since it's UI stuff, but
please try to take my changes into account
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?1161>
_______________________________________________
Message posté via/par Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
