Follow-up Comment #4, patch #1170 (project wesnoth):
The patch is only a partial solution. since we have gamemap_calllable,
team_callable, attack_analysis, ai_readonly_context, terrain_callable,
location_callable, move_callable, move_partial_callable,move_map_callable,
attack_type_callable, unit_callable, unit_type_callable.
12 callables. only location_callable has do_compare. fixing +2 of them leaves
us with 3/12 fixed. not good.
A better solution is to make "formula_callable::do_compare" pure virtual and
fix all subclasses, since comparing pointers in current
formula_callable::do_compare() is not good
Of course the patch is still good, but it does only 18% of work needed to fix
the bug. Also note that we need to compare different types of callable object
deterministically, as well (for example, moves and attacks may end up in a
same list, and the ordering needs to be deterministic)
Benetnash: are 'move_callable' and 'attack_callable' the only callables from
the above list that you need to fix for your scripts to work?
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?1170>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
