Update of patch #1319 (project wesnoth):
Status: None => Ready For Test
Assigned to: None => boucman
_______________________________________________________
Follow-up Comment #4:
yes, looks good. Still, one more thing:
you've included
+#ifdef _MSC_VER
+#pragma warning(push)
+//silence "inherits via dominance" warnings
+#pragma warning(disable:4250)
+#endif
directives in the new file (although the code you moved doesn't need them,
since they're related with AI contexts inheritance hierarchy, not with those
classes you're moved).
But, those MSVC-specific directives do the following:
1) store the current list of enabled warnings
2) disable a specific warning
So, at the end of file, another thing is needed:
3) restore the list of enabled warnings.
This is done by using:
#ifdef _MSC_VER
#pragma warning(pop)
#endif
If you do (1)-(2), but not (3), you disable that warning for
rest-of-compilation, which is not wanted behavior.
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?1319>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
