URL:
<http://gna.org/patch/?1757>
Summary: Make --disable-fribidi work again
Project: Battle for Wesnoth
Submitted by: nullnix
Submitted on: Thursday 07/22/2010 at 22:31
Priority: 5 - Normal
Status: None
Privacy: Public
Assigned to: None
Originator Email:
Open/Closed: Open
Discussion Lock: Any
_______________________________________________________
Details:
I've started to check every package on my system with a configure script to
see if every configure option works in isolation (a useful minimum, in any
case).
In Wesnoth 1.8 (tip of branch), --disable-fribidi no longer works: it breaks
every future invocation of PKG_CHECK_MODULES, and as one of those is
mandatory (lua), configuring fails.
The problem is twofold:
- the use of a shell if statement rather than AS_IF() means that autoconf
cannot tell that PKG_CHECK_MODULES is conditionally invoked, so first-call
initialization of this macro is only done when that conditional is true.
Unfortunately this initialization includes finding pkg-config itself...
- The FRIBIDI and OLD_FRIBIDI variables are not defined at all (not even to
nothing) if --disable-fribidi is set. AM_CONDITIONALs should always sit
outside conditional blocks. (This elicits a warning with recent Autoconf
versions even if --disable-fribidi is not specified.)
The attached patch fixes both of these bugs, and --disable-fribidi works
again.
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: Thursday 07/22/2010 at 22:31 Name: fribidi-disable.diff Size: 790B
By: nullnix
Make --disable-fribidi work again
<http://gna.org/patch/download.php?file_id=9547>
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?1757>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
