URL:
<http://gna.org/bugs/?16432>
Summary: tip of the day buttons don't show descriptions
Project: Battle for Wesnoth
Submitted by: aceman
Submitted on: Saturday 08/14/2010 at 18:08
Category: Bug
Severity: 2 - Minor
Priority: 5 - Normal
Item Group: User Interface
Status: None
Privacy: Public
Assigned to: None
Originator Email:
Open/Closed: Open
Discussion Lock: Any
Release: 1.8.4
Operating System: Linux
_______________________________________________________
Details:
The buttons in the tip of the day bar do not show correct descriptions
(tooltips) when the mouse hover over them. See the attachment.
The file titlescreen.cpp defines descriptions for them, but they seem not to
be used:
//- Texts for the menu-buttons.
//- Members of this array must correspond to the enumeration
TITLE_RESULT
static const char* button_labels[] = {
N_("TitleScreen
button^Tutorial"),
N_("TitleScreen
button^Campaign"),
N_("TitleScreen
button^Multiplayer"),
N_("TitleScreen button^Load"),
N_("TitleScreen
button^Add-ons"),
#ifndef DISABLE_EDITOR
N_("TitleScreen button^Map
Editor"),
#endif
N_("TitleScreen
button^Language"),
N_("TitleScreen
button^Preferences"),
N_("TitleScreen
button^Credits"),
N_("TitleScreen
button^Quit"),
// Only the
above buttons go into the menu-frame
// Next 2
buttons go into frame for the tip-of-the-day:
N_("TitleScreen
button^Previous"),
N_("TitleScreen button^Next"),
N_("TitleScreen
button^Help"),
// Next entry
is no button, but shown as a mail-icon instead:
N_("TitleScreen button^Help
Wesnoth") };
//- Texts for the tooltips of the menu-buttons
static const char* help_button_labels[] = { N_("Start a tutorial to
familiarize yourself with the game"),
N_("Start a new single
player campaign"),
N_("Play multiplayer
(hotseat, LAN, or Internet), or a single scenario against the AI"),
N_("Load a saved game"),
N_("Download usermade
campaigns, eras, or map packs"),
#ifndef DISABLE_EDITOR
N_("Start the map
editor"),
#endif
N_("Change the
language"),
N_("Configure the game's
settings"),
N_("View the credits"),
N_("Quit the game"),
N_("Show next tip of the
day"),
N_("Show Battle for
Wesnoth help") };
-------------------------------
The descriptions (help_button_labels) are only set at this loop in the code.
The break after Quit button may cause the tip buttons do not get their
descriptions initialized.
for(b = 0; b != nbuttons; ++b) {
buttons.push_back(button(screen.video(),sgettext(button_labels[b])));
buttons.back().set_help_string(sgettext(help_button_labels[b]));
max_width =
std::max<size_t>(max_width,buttons.back().width());
n_menubuttons = b;
if(b + TUTORIAL == QUIT_GAME) break; // Menu-frame ends at
the quit-button
}
-----------------------------------
While at it, the comment '2 buttons' is incorrect, there are 3 buttons
already. This is at 2 spots in the file.
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: Saturday 08/14/2010 at 18:08 Name: wesnoth-bug-tip_desc.png Size:
292kB By: aceman
<http://gna.org/bugs/download.php?file_id=9834>
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?16432>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
