URL:
<http://gna.org/bugs/?17342>
Summary: Traveler's Ring not working on dehydrated units
Project: Battle for Wesnoth
Submitted by: elvish_hunter
Submitted on: ven 17 dic 2010 18:09:48 GMT
Category: Bug
Severity: 3 - Normal
Priority: 5 - Normal
Item Group: Campaign
Status: None
Privacy: Public
Assigned to: None
Originator Email:
Open/Closed: Open
Discussion Lock: Any
Release: 1.9.3
Operating System: Windows XP
_______________________________________________________
Details:
In UtBS, Across the Harsh Sands, I noticed that, if the Traveler's Ring is
picked by an already dehydrated unit, such unit is not rehydrated, and will
never be until its level-up. The stderr gave me this output:
20101217 11:24:24 warning engine: variable_info: invalid WML array index,
hydrating_units[].attack.length
20101217 11:24:24 warning engine: variable_info: invalid WML array index,
hydrating_units[].variables.original_attack[].damage
20101217 11:24:24 warning engine: variable_info: invalid WML array index,
hydrating_units[].x
20101217 11:24:24 warning engine: variable_info: invalid WML array index,
hydrating_units[].y
So, I prepared a patch that removes the nested event, uses
[filter_condition], three variables (one to check if the ring was created, and
two to store its location), and clears such variables on victory. After
testing, it seems to work fine.
Patch is attached, I already ran wmllint, wmlscope and wmlindent on such
scenario. It includes also the bugfix for #17339.
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: ven 17 dic 2010 18:09:48 GMT Name: travel_ring.patch Size: 5kB By:
elvish_hunter
<http://gna.org/bugs/download.php?file_id=11614>
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?17342>
_______________________________________________
Messaggio inviato con/da Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
