URL:
<http://gna.org/patch/?2633>
Summary: Refactoring of the modification parsing code
Project: Battle for Wesnoth
Submitted by: None
Submitted on: Mon 11 Apr 2011 07:52:36 PM UTC
Priority: 3 - Low
Status: None
Privacy: Public
Assigned to: None
Originator Email:
Open/Closed: Open
Discussion Lock: Any
_______________________________________________________
Details:
While reading through image.cpp to prepare my proposal I have noticed the
ugly almoat 400 line long loop in the image::locator::load_image_sub_file
method. In the process of analysing it I have devised a way of refactoring it
into smaller pieces. This patch is an implementation of that idea.
Essentially I have changed the function functor hierarchy to modification
class hierarchy and have created a set of functions to load them from strings.
I have described the changes in more detail on my proposal page
<http://wiki.wesnoth.org/SoC2011_Automagic#Refactoring_modificaiton_parsing>.
I would like to point out that I have been requested to submit patches as
soon as possible and I do so, but the patch hasn't been thoroughly tested. I
will write some unit tests for the modifications to check if they work
correctly when I'll have time (I'm pretty busy until Thursday). Note that this
implementation makes unit testing of modifications possible.
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?2633>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
