URL:
  <http://gna.org/patch/?3120>

                 Summary: Redundant "if" in clear_shroud_loc()
                 Project: Battle for Wesnoth
            Submitted by: jamit
            Submitted on: Sat 04 Feb 2012 12:59:22 PM EST
                Priority: 3 - Low
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

This is just something I noticed as I started looking at the C++ code. At some
point an "if" statement got doubled up (as in

if ( res )
    if (res )
        do stuff ).

This patch would get rid of the useless second "if" and inline the
conditional. Not a big deal since the compiler is probably doing the exact
same thing behind the scenes, but it makes the code look saner. :)



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sat 04 Feb 2012 12:59:22 PM EST  Name: clear_shroud_loc-simplified.diff 
Size: 2kB   By: jamit

<http://gna.org/patch/download.php?file_id=15007>

    _______________________________________________________

Reply to this item at:

  <http://gna.org/patch/?3120>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs

Reply via email to