Follow-up Comment #6, patch #3176 (project wesnoth):
I'm somewhat confused about the masses of patches you submit; could you please
make clear which later patch invalidates which previous one and also not
submit alternative versions !?
comments on remove/set fog patch:
-The tags should be named remove_fog and place_fog then, since they are
obviously meant to be analog to remove_shroud and place_shroud. And as opposed
to a recalculation of fog based onto the positions of units (which can be
necessary if DSU is used and should already be handled by
[redraw]clear_shroud=yes, affecting both shroud and fog).
-Did you look into get_sides_vector() ? You should not call it, instead just
do
side_filter ssf(cfg);
like in [modify_ai] for instance.
(The rule I follow is "extra [filter*] tag for a Standard*Filter only if
key/tag name collisions exist or are likely in the future.")
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?3176>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
