Follow-up Comment #3, patch #3527 (project wesnoth):
I like this idea. I guess it might be even more useful when dealing with
multiple leaders with distinct recruit and/or recall lists.
I took a look at the patch and found a few things, though:
One hunk adds a blank line with a trailing tabstop to
src/construct_dialog.cpp. That should be removed.
Another hunk adds a commented out line to the same file around line 483:
switch(b->second)
{
case BUTTON_EXTRA:
case BUTTON_CHECKBOX:
check_button_height += btn->height() +
button_height_padding;
break;
case BUTTON_EXTRA_LEFT:
//case BUTTON_FULL_LEFT:
case BUTTON_CHECKBOX_LEFT:
left_check_button_height += btn->height() +
button_height_padding;
break;
case BUTTON_TOP:
top_button_height += btn->height() +
button_height_padding;
break;
case BUTTON_STANDARD:
default:
break;
}
The BUTTON_FULL_LEFT enum member does not have the same value as
BUTTON_EXTRA_LEFT, so the code flow here actually leads to the default case
with the commented out case. If this is intentional, then the commented out
line doesn't really belong to the case chain handling BUTTON_EXTRA_LEFT and
BUTTON_CHECKBOX_LEFT.
A hunk adds the following in src/menu_events.cpp around line 1057:
if (res == recruit_button_value) recruit (side_num, last_hex);
The whitespace between the method name and the argument list's opening
parenthesis needs to go.
Other than that, this looks good enough for me to commit.
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?3527>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
