Follow-up Comment #1, patch #3777 (project wesnoth):
Some notes I also left in IRC
- what would happen if in language x Saturday is translated as Sunny?
- strcpy is evil do not use it, especially not when the function signature has
a maxsize parameter.
- the std::setlocale on line 342 is not done exception safe regarding
restoring it, the return on line 351 also will leave us with a modified
locale.
- I'm still not sure whether the approach of this patch is the right way. Also
not sure whether we want to add extra strings for translators.
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?3777>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
