URL:
  <http://gna.org/bugs/?21488>

                 Summary: Standard Location Filter broken when only x= or y=
is given
                 Project: Battle for Wesnoth
            Submitted by: mattsc
            Submitted on: Thu 16 Jan 2014 04:30:03 AM GMT
                Category: Bug
                Severity: 5 - Blocker
                Priority: 7 - High
              Item Group: WML
                  Status: None
                 Privacy: Public
             Assigned to: fendrin
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: 1.11.8
        Operating System: OS X 10.9

    _______________________________________________________

Details:

In 1.11.8, Standard Location Filters return the wrong set of hexes when only
one of x= or y= is given (as opposed to both or neither).  This event

    [event]
        name=start
     
        [store_locations]
            x=5-8
            variable=tmp_locs
        [/store_locations]
     
        {MESSAGE narrator "" "" _"$tmp_locs.length"}
    [/event]

should store only hexes with x values in the range 5-8, but stores all hexes
on the map.  By contrast, this event

    [event]
        name=start
     
        [store_locations]
            x,y=5-8,1-99
            variable=tmp_locs
        [/store_locations]
     
        {MESSAGE narrator "" "" _"$tmp_locs.length"}
    [/event]

works just fine.  I have not done exhaustive tests, but everything else in
SLFs still appears to work.

This worked correctly in 1.11.7, but not any more in 1.11.8.  ‘git bisect’
indicates that this was broken in commit f979609ccf
<https://github.com/wesnoth/wesnoth-old/commit/f979609ccfa5fbd0392f6f3b67f1c8ce4414efb4>,
so I am assigning it to fendrin.




    _______________________________________________________

Reply to this item at:

  <http://gna.org/bugs/?21488>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs

Reply via email to