Update of bug #21808 (project wesnoth):

                Priority:              5 - Normal => 7 - High               
                 Release:              1.13.0-dev => 1.11.7                 

    _______________________________________________________

Follow-up Comment #2:

Correction to the previous post:

Since at least 1.10.6, we have the following (minor) bug:

If a game has only reserved slots available, it is displayed with yellow
highlights. Any player who has a slot reserved may join, however a player
without a slot reserved will be kicked back to lobby with the message
"<server> You are an observer.", even if observation is allowed. If the
reserved slots are filled or set to other controllers, then observers may join
normally.

Starting in 1.11.7, we have a major bug. Here's exactly how I have reproduced
it. (Basically I follow EP's recipe, in a seemingly unrelated bug:
https://gna.org/bugs/?21797)

Start any networked game with allow observers enabled, with at least one
remote player (besides the host). It may have some droids as well, it may not,
it doesn't seem to matter. It can be checked that observers may join normally
before and after the start of the game. 

On turn 1, (P2) saves the game and quits, then hosts a reload. Now observers
may not join the reload, before or after the start of game. ("Attempted to
observe a game that doesn't allow obesrvers. (You probably joined the game
shortly after it filled up.)") This happens regardless of "yellow" or "white"
color highlight of the game, and regardless of the observer eye icon in the
lobby.

In master, if this is done using a localhost wesnothd instance with debugging
on, from inspecting the output of the "(g*)->allow_observers()" flag the
server actually does believe that observers are not allowed in this game,
despite the clients all displaying that they are permitted.

https://github.com/wesnoth/wesnoth/commit/f8a01890d119742ffc132771493489546f1c0052#diff-21c82be7cd6468901691490708d2f916R2290

    _______________________________________________________

Reply to this item at:

  <http://gna.org/bugs/?21808>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs

Reply via email to