URL:
<http://gna.org/bugs/?23632>
Summary: Save file names are truncated/ellipsized on disk,
breaking the Filter option in Load Game
Project: Battle for Wesnoth
Submitted by: shadowmaster
Submitted on: Tue 02 Jun 2015 04:29:52 AM CLT
Category: Bug
Severity: 4 - Important
Priority: 3 - Low
Item Group: User Interface
Status: None
Privacy: Public
Assigned to: shadowmaster
Originator Email:
Open/Closed: Open
Discussion Lock: Any
Release: All, apparently
Operating System: All
_______________________________________________________
Details:
The names of save files are ellipsized on disk, apparently just so they won't
exceed 200 px in length when rendered on the screen using Wesnoth's default
font configuration (see replay_savegame::create_filename() in savegame.cpp on
master). This appears to be the case since as far back as commit
369d88c5690c8d92abef107c9aee136a6124f9c6
<https://github.com/wesnoth/wesnoth/commit/369d88c5690c8d92abef107c9aee136a6124f9c6>,
from November 2005.
I decided I don't need to explain why this is the wrong thing to do.
We should ellipsize filenames on disk char count-wise instead, setting the
limit to something safe (127 chars maybe? older Windows filesystems/versions
have a filename limit of 255 but we also want to avoid hitting path limits),
and leaving it up to the Wesnoth UI to ellipsize them further if needed to
work around limitations in the GUI1 listbox implementation. This way, it
should be possible to enter a full scenario name in the Filter box and get all
the relevant results instead of missing a few due to the permanent
ellipsization.
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?23632>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
