Author: mordante
Date: Sun Feb 27 16:20:01 2011
New Revision: 48667
URL: http://svn.gna.org/viewcvs/wesnoth?rev=48667&view=rev
Log:
Catch exception by reference.
Issue found by cppcheck.
Modified:
trunk/src/server/forum_user_handler.cpp
Modified: trunk/src/server/forum_user_handler.cpp
URL:
http://svn.gna.org/viewcvs/wesnoth/trunk/src/server/forum_user_handler.cpp?rev=48667&r1=48666&r2=48667&view=diff
==============================================================================
--- trunk/src/server/forum_user_handler.cpp (original)
+++ trunk/src/server/forum_user_handler.cpp Sun Feb 27 16:20:01 2011
@@ -65,7 +65,7 @@
try {
hash = get_hash(name);
- } catch (error e) {
+ } catch (error& e) {
ERR_UH << "Could not retrieve hash for user '" << name << "' :"
<< e.message << std::endl;
return false;
}
@@ -94,7 +94,7 @@
try {
hash = get_hash(name);
- } catch (error e) {
+ } catch (error& e) {
ERR_UH << "Could not retrieve hash for user '" << name << "' :"
<< e.message << std::endl;
return "";
}
@@ -113,7 +113,7 @@
// Make a test query for this username
try {
return mysql_fetch_row(db_query("SELECT username FROM " +
db_users_table_ + " WHERE UPPER(username)=UPPER('" + name + "')"));
- } catch (error e) {
+ } catch (error& e) {
ERR_UH << "Could not execute test query for user '" << name <<
"' :" << e.message << std::endl;
// If the database is down just let all usernames log in
return false;
@@ -126,7 +126,7 @@
try {
return get_writable_detail_for_user(name, "user_is_moderator")
== "1";
- } catch (error e) {
+ } catch (error& e) {
ERR_UH << "Could not query user_is_moderator for user '" <<
name << "' :" << e.message << std::endl;
// If the database is down mark nobody as a mod
return false;
@@ -139,7 +139,7 @@
try {
write_detail(name, "user_is_moderator", is_moderator ? "1" :
"0");
- } catch (error e) {
+ } catch (error& e) {
ERR_UH << "Could not set is_moderator for user '" << name << "'
:" << e.message << std::endl;
}
}
@@ -179,7 +179,7 @@
std::string fuh::get_hash(const std::string& user) {
try {
return get_detail_for_user(user, "user_password");
- } catch (error e) {
+ } catch (error& e) {
ERR_UH << "Could not retrieve password for user '" << user <<
"' :" << e.message << std::endl;
return time_t(0);
}
@@ -188,7 +188,7 @@
std::string fuh::get_mail(const std::string& user) {
try {
return get_detail_for_user(user, "user_email");
- } catch (error e) {
+ } catch (error& e) {
ERR_UH << "Could not retrieve email for user '" << user << "'
:" << e.message << std::endl;
return time_t(0);
}
@@ -198,7 +198,7 @@
try {
int time_int = atoi(get_writable_detail_for_user(user,
"user_lastvisit").c_str());
return time_t(time_int);
- } catch (error e) {
+ } catch (error& e) {
ERR_UH << "Could not retrieve last visit for user '" << user <<
"' :" << e.message << std::endl;
return time_t(0);
}
@@ -208,7 +208,7 @@
try {
int time_int = atoi(get_detail_for_user(user,
"user_regdate").c_str());
return time_t(time_int);
- } catch (error e) {
+ } catch (error& e) {
ERR_UH << "Could not retrieve registration date for user '" <<
user << "' :" << e.message << std::endl;
return time_t(0);
}
@@ -221,7 +221,7 @@
try {
write_detail(user, "user_lastvisit", ss.str());
- } catch (error e) {
+ } catch (error& e) {
ERR_UH << "Could not set last visit for user '" << user << "'
:" << e.message << std::endl;
}
}
@@ -261,7 +261,7 @@
db_query("INSERT INTO " + db_extra_table_ + " VALUES('"
+ name + "','" + value + "','0')");
}
db_query("UPDATE " + db_extra_table_ + " SET " + detail + "='"
+ value + "' WHERE UPPER(username)=UPPER('" + name + "')");
- } catch (error e) {
+ } catch (error& e) {
ERR_UH << "Could not set detail for user '" << name << "': " <<
e.message << std::endl;
}
}
@@ -271,7 +271,7 @@
// Make a test query for this username
try {
return mysql_fetch_row(db_query("SELECT username FROM " +
db_extra_table_ + " WHERE UPPER(username)=UPPER('" + name + "')"));
- } catch (error e) {
+ } catch (error& e) {
ERR_UH << "Could not execute test query for user '" << name <<
"' :" << e.message << std::endl;
return false;
}
_______________________________________________
Wesnoth-commits mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-commits
