Author: tschmitz
Date: Thu Jul  7 07:48:50 2011
New Revision: 50195

URL: http://svn.gna.org/viewcvs/wesnoth?rev=50195&view=rev
Log:
Added todos.

Modified:
    trunk/src/whiteboard/manager.cpp
    trunk/src/whiteboard/validate_visitor.cpp

Modified: trunk/src/whiteboard/manager.cpp
URL: 
http://svn.gna.org/viewcvs/wesnoth/trunk/src/whiteboard/manager.cpp?rev=50195&r1=50194&r2=50195&view=diff
==============================================================================
--- trunk/src/whiteboard/manager.cpp (original)
+++ trunk/src/whiteboard/manager.cpp Thu Jul  7 07:48:50 2011
@@ -691,7 +691,9 @@
                if (selected_unit &&
                                (it = 
viewer_actions()->find_first_action_of(selected_unit)) != 
viewer_actions()->end())
                {
+                       ///@todo Shouldn't it be "find_last_action_of" instead 
of "find_first_action_of" above?
                        viewer_actions()->remove_action(it);
+                       ///@todo Shouldn't we probably deselect the unit at 
this point?
                }
                else if (highlighter_ && (action = 
highlighter_->get_delete_target()) &&
                                (it = 
viewer_actions()->get_position_of(action)) != viewer_actions()->end())

Modified: trunk/src/whiteboard/validate_visitor.cpp
URL: 
http://svn.gna.org/viewcvs/wesnoth/trunk/src/whiteboard/validate_visitor.cpp?rev=50195&r1=50194&r2=50195&view=diff
==============================================================================
--- trunk/src/whiteboard/validate_visitor.cpp (original)
+++ trunk/src/whiteboard/validate_visitor.cpp Thu Jul  7 07:48:50 2011
@@ -50,6 +50,7 @@
 bool validate_visitor::validate_actions()
 {
        int action_number = 1;
+       ///@todo We can optimize this by making the side_actions::iterator 
available to accept()
        foreach(action_ptr action, *side_actions_)
        {
                DBG_WB << "Action #" << action_number << "\n";


_______________________________________________
Wesnoth-commits mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-commits

Reply via email to