Author: timotei
Date: Sat Aug 6 23:12:33 2011
New Revision: 50631
URL: http://svn.gna.org/viewcvs/wesnoth?rev=50631&view=rev
Log:
eclipse plugin: Fix some warnings
Modified:
trunk/utils/umc_dev/org.wesnoth.ui/src/org/wesnoth/ui/labeling/wmldoc/WMLDocHandler.java
trunk/utils/umc_dev/org.wesnoth/src/org/wesnoth/views/AddonsView.java
trunk/utils/umc_dev/org.wesnoth/src/org/wesnoth/wizards/generator/WizardGenerator.java
Modified:
trunk/utils/umc_dev/org.wesnoth.ui/src/org/wesnoth/ui/labeling/wmldoc/WMLDocHandler.java
URL:
http://svn.gna.org/viewcvs/wesnoth/trunk/utils/umc_dev/org.wesnoth.ui/src/org/wesnoth/ui/labeling/wmldoc/WMLDocHandler.java?rev=50631&r1=50630&r2=50631&view=diff
==============================================================================
---
trunk/utils/umc_dev/org.wesnoth.ui/src/org/wesnoth/ui/labeling/wmldoc/WMLDocHandler.java
(original)
+++
trunk/utils/umc_dev/org.wesnoth.ui/src/org/wesnoth/ui/labeling/wmldoc/WMLDocHandler.java
Sat Aug 6 23:12:33 2011
@@ -49,8 +49,6 @@
public void process( XtextResource resource )
throws Exception
{
- WMLDocInformationPresenter presenter_ = null;
-
ITextSelection selection = ( ITextSelection )
editor
.getSelectionProvider( ).getSelection( );
Point positionRelative = editor
@@ -75,29 +73,23 @@
editedFile.getProject( ) )
.getDefines( ).get( macro.getName( ) );
if( define != null ) {
- if( presenter_ == null ) {
- presenter_ = new
WMLDocInformationPresenter(
- editor.getSite( ).getShell( ),
- new WMLDocMacro( define ),
- positionAbsolute );
- presenter_.create( );
- }
- presenter_.open( );
+ WMLDocInformationPresenter presenter = new
WMLDocInformationPresenter(
+ editor.getSite( ).getShell( ),
+ new WMLDocMacro( define ),
+ positionAbsolute );
+ presenter.create( );
+ presenter.open( );
}
}
else if( grammarElement instanceof WMLTag ) {
- if( presenter_ == null ) {
- presenter_ = new
WMLDocInformationPresenter(
- editor.getSite( ).getShell( ),
- new WMLDocTag(
- editedFile,
- installName,
- ( ( WMLTag )
grammarElement )
- .getName( ) ),
- positionAbsolute );
- presenter_.create( );
- }
- presenter_.open( );
+ WMLDocInformationPresenter presenter = new
WMLDocInformationPresenter(
+ editor.getSite( ).getShell( ),
+ new WMLDocTag( editedFile, installName,
+ ( ( WMLTag ) grammarElement )
+ .getName( ) ),
+ positionAbsolute );
+ presenter.create( );
+ presenter.open( );
}
}
} );
Modified: trunk/utils/umc_dev/org.wesnoth/src/org/wesnoth/views/AddonsView.java
URL:
http://svn.gna.org/viewcvs/wesnoth/trunk/utils/umc_dev/org.wesnoth/src/org/wesnoth/views/AddonsView.java?rev=50631&r1=50630&r2=50631&view=diff
==============================================================================
--- trunk/utils/umc_dev/org.wesnoth/src/org/wesnoth/views/AddonsView.java
(original)
+++ trunk/utils/umc_dev/org.wesnoth/src/org/wesnoth/views/AddonsView.java Sat
Aug 6 23:12:33 2011
@@ -176,7 +176,7 @@
public void run( )
{
downloadAddon( );
- };
+ }
};
manager.add( downloadAction );
}
Modified:
trunk/utils/umc_dev/org.wesnoth/src/org/wesnoth/wizards/generator/WizardGenerator.java
URL:
http://svn.gna.org/viewcvs/wesnoth/trunk/utils/umc_dev/org.wesnoth/src/org/wesnoth/wizards/generator/WizardGenerator.java?rev=50631&r1=50630&r2=50631&view=diff
==============================================================================
---
trunk/utils/umc_dev/org.wesnoth/src/org/wesnoth/wizards/generator/WizardGenerator.java
(original)
+++
trunk/utils/umc_dev/org.wesnoth/src/org/wesnoth/wizards/generator/WizardGenerator.java
Sat Aug 6 23:12:33 2011
@@ -100,7 +100,7 @@
tags.append( ( ( WizardGeneratorPageTag ) page ).getContent( )
);
}
else {
- ; // skip 404 pages
+ // skip 404 pages
}
}
result += ( keys.toString( ) + tags.toString( ) );
_______________________________________________
Wesnoth-commits mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-commits
