Nicolas Weeger wrote:
Hello.
Here a two small patches to fix compilation under Windows.
The first, pc.patch, is against publish_campaign.cpp. Windows doesn't
handle variable definition in for loops the same as Unix, so declaration
should be before loops when using the same variable twice.
This is not a matter of Windows vs Unix, this is a matter of broken
compilers vs standard-compliant ones :-)
Are you using Visual C++ 6? VC7 has an option to use the standard
variable-scoping instead of the pre-standard scoping VC6 used.
According to the CodingStandards page on the Wiki, VC6 is still
supported, and its scoping rules must be taken into account:
http://www.wesnoth.org/wiki/CodingStandards#Respect_for_loop_scoping_of_different_platforms
Is this rule still valid? I think I heard Dave tell that we could now
support only VC7. If it's not, it's time to update the wiki.
Cheers,
Ayin
