I'm sorry, but I think this patch is too complicated to add after a
feature freeze. It modifies a data file, and four functions across three
source files. It takes me longer than two minutes to comprehend. This
leaves the possibility of bugs being added and so I can't allow it.
It's far more complicated than, say, my change to add 'berserk' back in,
which is about the furthest I would be happy to violate feature freeze by.
David
Yann Dirson wrote:
On Wed, Jun 01, 2005 at 09:01:36PM +0200, Yann Dirson wrote:
We could start by only setting a flag on a global basis, possibly in a
new game.cfg section, and append " (incomplete)" to the relevant
translations. That would be quite easy to do, and has only a small
potential for disruption. That may be true also for a simple warning
dialog to be displayed both when a language has been selected, and at
startup.
This is a preliminary patch for review. It features no dialog yet.
It adds an "incomplete_translations" list field in the game_config,
and appends " [incomplete]" to the displayed language name.
I also tried a modification of the languagedef_lessthan_p(), which
looked like a simple way to sort all incomplete ones down the list,
but it is unfortunately currently not used. Any simple idea to get
around this ? (I was thinking about something like renaming this func
to operator< and calling std::sort). Should we even try at this point
in the freeze ?
Best regards,
