I have tracked down the source of bug 13505 which causes ai-player controlled
victory in a scenario to end the campaign. A quick fix is to make the change
at the bottom of this email. The change is to the is_observer(const
std:vector<team>& teams) function. I am not sure when exactly this was put
into place, thus breaking the ability to do an AI walkthrough. Normally I
would just commit this change, but since we are in a near code freeze, even
though this is a bug fix, I figured that I would see if someone else could look
at this fix first. My only concern is that it might break multiplayer
observors somehow, and since I can't easily check this, it would be good if
someone could test it, or failing that at least stare at the code and make sure
I am not doing something silly.
Thanks
John, aka darthfool
RCS file: /cvsroot/wesnoth/wesnoth/src/playlevel.cpp,v
retrieving revision 1.209
diff -u -r1.209 playlevel.cpp
--- playlevel.cpp 18 Jun 2005 22:13:09 -0000 1.209
+++ playlevel.cpp 27 Jun 2005 14:49:54 -0000
@@ -112,7 +112,7 @@
bool is_observer(const std::vector<team>& teams)
{
for(std::vector<team>::const_iterator i = teams.begin(); i !=
teams.end(); ++i) {
- if(i->is_human()) {
+ if(i->is_human() || i->is_persistent()) {
return false;
}
}
--
-------------------------------------------------------------------
"In theory, theory and practice are the same,
but in practice they're different."
-------------------------------------------------------------------
John W. C. McNabb
-------------------------------------------------------------------
