Hi,

If I recall correctly, Dave introduced poolalloc.c and malloc.c to implement 
an alternate memory allocator for C++ objects in Wesnoth that was intended to 
help optimize our memory usage. However, they were disabled and (as far as I 
can tell) abandoned because they caused many hard-to-debug issues on certain 
platforms, presumably x86_64.

Judging by the name, they were intended to reduce memory fragmentation. I'm 
not sure this is still an important issue after several commits by silene 
(config class) and alink (image cache, terrain builder) advertising 
significant memory usage and performance improvements during 2010-2011. I 
haven't made any benchmarks myself, and it's important to consider that the 
codebase has grown significantly larger and complex (terrain graphics WML in 
particular) since the point at which the alternate allocator entered mainline, 
in late 2008.

Considering they aren't being maintained or used by anything other than a 
build option that's decidedly disabled by default (a user asked me about it 
the other day), would it be all right if they were removed from the source 
tree along with any references to them in the cmake and scons source file 
listings?

-- 
Regards
  Ignacio Riquelme Morelle <shadowmaster>

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
Wesnoth-dev mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-dev

Reply via email to