Hi Chris, On Fri, May 02, 2014 at 06:11:36PM -0400, chris beck wrote: > After some discussion on the forums about minor problems with our rng, > mordante pointed out boost::mt19937 as a nice rng which might be a > candidate to replace our rng.
I'm not sure what the exact problem on the forums was. But if the problem is that the RNG seems unfair, I think it is a non-issue. I fear the biggest problem people have with the RNG is that the RNG doesn't give them the result _they_ want. So a mage with a 70% hit change should not be able to miss three shots… unless of course it is the opponent's mage. However we had some issues due to the range (32K) of the current RNG and WML wanted to use a larger range (see comment starting at line 2053 in game_events/action_wml.cpp). So for that reason I would like to move to a generator with a larger range. > In my judgment, the branch would only be worth it if we are willing to > adopt the boost::random library from version 1.40.0 at least, from 2009. In that case we should update our Boost dependencies in the INSTALL file and the build systems. > If things proceed at the current pace and there are no unforeseen problems > / objections, then I expect that from my end, I would be ready to merge > into wesnoth master within a week. I haven't looked at the code, but I've no objection against moving our RNG to the boost:mt19937 as long as it is for master only. -- Regards, Mark de Wever aka Mordante/SkeletonCrew _______________________________________________ Wesnoth-dev mailing list [email protected] https://mail.gna.org/listinfo/wesnoth-dev
