On Tue, 13 Feb 2001, Vladi Belperchinov-Shabanski wrote:

> hi!
>
/.../
>   I've contacted Hrvoje Niksic and understood that very similar
>   patch has been applied which reports current rate on every
>   dot line. So I've been advised to post message here to get
>   different opinions...

Back in wget 1.5.3 I used to run the wget-new-percentage patch with much
delight, and I felt a bit sadden when I forced myself to at last remove
1.5.3 in favour for 1.6 that still didn't have this highly useful feature.

now, wget1.7-dev got a variant of this feature, however there is still
some work to be done I believe:

==> RETR xv-3.10a-13.i386.rpm ... done.
Length: 1,083,219 [820,419 to go] (unauthoritative)

          [ skipping 250K ]
  250K ,,,,,,.... .......... .......... .......... .......... 28% @-305780.35 B/s
  300K .......... .......... .......... .......... .......... 33% @ 195.31 KB/s

-305780.35B/s ?

Since it is a dev-release this sort of thing is to expect of course, but
let's compare to the new-percentage-patch (I'll just copy from your url
since I don't have the time to patch an old wget :/ )

HTTP request sent, awaiting response... 200 OK
Length: 235,173 [application/x-tar]

    0K .......... .......... .......... .......... .......... 21%   0:00 7.31M
   50K .......... .......... .......... .......... .......... 43%   0:00 8.53M

The output isn't exactly identical - for one you don't get the ugly "@"
after each line (yes I call it ugly, using "@" as an abbreviation for "at"
is not only wrong, it doesn't look very good visually in my opinion) -
instead we get 0:00 which is, even if it doesn't show very good here, the
time that's left until the download is complete! Nice feature, ne?

The new-percentage-patch did a very good job on 1.5.3 and handles the -c
option correct, so I don't see why the 1.7-dev should reinvent the wheel
in this case. At least not without a good reason (which at least I fail to
see here, but then again what do I know).

For what it's worth, if you decide to not merge the new-percentage-patch
and continue with your wheel, at least *please* remove the "@" in the
output.. ;-)


Best regards
 Henrik van Ginhoven, Sweden
 9799-5
 Everyone a story but they end the same

Reply via email to