On Tue, Apr 10, 2001 at 02:49:00 +0200, Hrvoje Niksic wrote:

> > i'm proposing that -np should _not_ take affect when you are dealing
> > with a page requisite (anything other than a .htm or a .html).
> 
> Yes, `-p' should override `-np' for the files that are downloaded only
> because of `-p'.

excellent, glad to see that people would find it useful

> If memory serves me, I think you need to free SUF after using it.
> I'll leave it to Dan (author of `--page-requisits' and an active
> maintainer) to review the patch before applying it.

yeah, i fixed the free(suf) pretty fast :)

okay, after digging around a bit more in the wget 1.60 code, and
looking at wget CVS code, i'm convinced this patch is a lot more
non-trivial than i think it is.  adding the above option seems
to break things like relative link conversion -- an html such as
http://www.blah.com/html/html1.html which has a tag like <img
src="http://www.blah2.com/images/image.jpg"> will end up with a
link like <img src="http://www.blah.com/html/../../www.blah2.com/images/image.jpg">,
which is most definitely wrong.

i don't have time in the next few days to do this, but i'll get
around to doing this sometime next week.  (my current patch in
CVS is much more planned and well-architectured than the 5-line
hack i presented before.)  sorry for any inconvenience!


-- 
#ozone/algorithm <[EMAIL PROTECTED]>          - trust.in.love.to.save

Reply via email to