On Tue, 21 Aug 2001, Ian Abbott wrote:

> Nice patch. I think it can be improved by only sending the SIZE command
> if the file already exists (has a non-zero size, i.e. restval parameter
> in function getftp is non-zero).

Yep, good plan, like it.

> I have attached a slightly modified version of Dave Turner
> <[EMAIL PROTECTED]>' s patch to add the non-zero restval test,
> remove an unused variable 's' from function ftp_size, and I have
> created the patch using the command cvs diff -uR to make it relative to
> the current CVS sources for wget-1.7.1-pre1.

Many thanks, Ian.  I just realised there's another minor bug in the patch:
I think the ./configure script ought to check for <errno.h> and behave
sensibly if it doesn't exist.  I'm afraid I don't know much about
autoconf: Learning it is on my TODO list, but so is climbing Everest...

-- 
Dave Turner                            http://linux.clare.cam.ac.uk/~dct25
[EMAIL PROTECTED]                                   +44 7773 784486 (Orange)

Quidquid latine dictum sit, altum viditur [Quotes in Latin sound profound]

Reply via email to