Just a couple of note with cookies if someone hasn't already pointed
them out

When using a proxy server, there will be a mismatch in
check_domain_match() and fail on debug step 4

Because the u->host will equal the proxy server if used whilst comparing
against cookie->domain name  (ie using proxy.myserver.com will show up
in u->host when we should be actually using u->proxy->host)

My fix for this was to change the call to header process to send through
the actual data sent to the proxy rather than the proxy data itself....

      /* Try getting cookies. */
      if (opt.cookies)
          if (header_process (hdr, "Set-Cookie", set_cookie_header_cb,
ou))
              goto done_header;

Just changing u to ou in the code above in http.c



Secondly as a suggestion...

the parsing of the cookie domain name will fail on many websites which
have the domain (domainname.com) without the . in front. Places like
altavista.com will fail but correct ones like google.com will pass

The section failing is section 4 and I need it for a particular website
I am parsing. Guess this doesn't match the rfc2109 standards? how about
just putting a . in front if one isn't detected just so cookies on these
websites work?

I need to find some hack how to do this and was thinking of putting it
in parse_set_cookies() before returning the domain name.

Anyhow excellent work putting this program together

Thanks
Matt


Reply via email to