On 7 Nov 2001, at 23:07, Hack Kampbjørn wrote:

> Ed Powell wrote:
> > I had to change:
> > 
> >         assert (ch == '\'' || ch == '"');
> > 
> > to:
> > 
> >         assert (ch == '\'' || ch == '\"');
> > 
> > Otherwise, it would not compile... it was, I think, interpreting the ",
> > rather than using it literally.  Escaping it appears to have fixed the
> > problem.
> 
> Right conclusion, wrong fix. Fix the broken software not the correct
> one, i.e. your fix breaks wget on another broken platform (read the
> below links if cannot guess which). You don't want to use Apple's
> precompiler anyway.

Agreed that you don't want to use Apple's precompiler, but I 
couldn't tell from the links you posted what platform the "fix" 
fails to compile on. There was one reference to VC++ 5.0 breaking, 
but that was for the "unfixed" version.

Reply via email to