>
>
>This is a problem, and part of the reason why the patch is so simple
>in its current form. A correct patch must modify struct address_list
>to hold a list of IP addresses, each of which can be either an IPv4
>address or an IPv6 address. It could be something like:
>
>struct ip_address {
> enum { ADDR_IPV4, ADDR_IPV6 } type;
> union {
> ipv4_address ipv4;
> ipv6_address ipv6;
> } addr;
>};
>
>with the appropriate #ifdefs for when IPv6 is not available.
>ipv6_address might also need to contain the "scope" information. (I
>don't know what that is, but I trust that you do. I've been told that
>IPv6 addresses were "scoped".)
>
Ok first we don't need this difference. I think it's not so easy than it
first seem's.
Because IPv6 is an superset of IPv4 there is an representation fo IPv4
Adresses.
2. If i made today an optimized patch there i put the ifdef's in an
small inline function.
+ Make it much easyer to switch per command line the default IPv4 IPv6
+ it's manly used for 3 Things set/get (ip_family,ip_port,ip_address)
and get_size>The address_list_* functions should be modified to either return such >a data structure, *or* (perhaps simpler) to provide the way for the >caller to query which kind of address it's dealing with. > Nope if the patch becomes clean ( it was not because i wrote it after i it wase 01:00 very long day) then it become clearer why not. >Also, you should get rid of the global variable named as vaguely as >`family'. Also, for FTP we need to support the extended IPv6 >commands. > The family wase bad choosen this is right. But the trouble is i only know much on the protocol side (tcp) and not so much on the ftp side. >Your patch seems to introduce possibly non-portable functions such as >inet_pton and gethostbyname2 without checking whether they exist. > Thats correct i only knew they are avaible on Linux and BSD, but this is the ground i make the ifdefs. And i think that this to call's can checked from Makefile. Or easely replaced with more compatible (if exists). >IPv6 support is not easy to add to an application heavily relying on >IPv4, such as Wget. I wouldn't say that your patch is "dirty" or >anything like it, but the fact is that in its current form it cannot >resemble the changes needed to fully support IPv6. > I know this, but i think i can make the tcp sektion clean 4/6 enable. Http is also no problem. The only think i not know is the ext ftp commands for v6. Cu Thomas >
smime.p7s
Description: S/MIME Cryptographic Signature
