Hello,
> > To talk about maintenance stuff, I counted "#if" (or "#ifdef") in the
> > code:
> > original cvs our code
> > host.c 19 8
> > connect.c 27 17
>
> But didn't you remove `--without-ipv6'? That way you got rid of all
> the #ifdef IPV6, and the count of ifdefs naturally decreased.
Yes, this is our point. You can implement "wget" without
--disable-ipv6. And you can reduce #ifdef.
Even if the "wget" community wants to re-implement --disable-ipv6,
just one #ifdef will be introduced to host.c:
#ifdef ENABLE_IPV6
hints.ai_family = AF_UNSPEC;
#else
hints.ai_family = AF_INET;
#endif
> So style improvement is the principal motivation for your change? I
> assumed that there were other reasons, with the improved style being
> just a benefit.
My original motivation is that "wget" ver 1.9 does not work on NetBSD
since mapped addresses are used. This problem has been fixed in the
CVS.
My current motivation is style improvement. Since people misunderstood
the new style, which you can see in Thomas's summary, we would like to
show that it was misunderstanding.
> "Better" style is often a matter of taste. Your patch makes some
> things more elegant (it deletes the custom "ip_address" type,
> simplifies the implementation of lookup_host and deletes stuff from
> connect.c), but makes others less elegant (the interface to
> lookup_host and connect_to_ip, embedding instances of sockaddr_storage
> into address_list). The compromises you chose are not inherently
> better or worse than ours, they're different. Personally I prefer the
> current approach.
Now I think you understand our point. And you think it's a matter of
taste. It's OK for us.
What we would like to avoid is misunderstanding.
--Kazu
