[EMAIL PROTECTED] (Steven M. Schweda) writes: >> > 1. I'd say that code like "if ( sizeof(number) == 8 )" should have >> > been a compile-time #ifdef rather than a run-time decision. >> >> Where do you see such code? grep 'if.*sizeof' *.c doesn't seem to >> show such examples. > > As I recall, it was in someone's suggested changes. Perhaps: > > http://software.lpetrov.net/wget-LFS/wget-LFS-20041113.patch
Oh, OK. I thought you were referring to my LFS patch. >> > The Info-ZIP code uses one function with a ring of string buffers to >> > ease the load on the programmer. >> >> That makes sense. I assume the print function also receives an >> integer argument specifying the ring position? > > Why assume? Why not look? Sorry about that. It is no small task to study Info-ZIP's source code. I did plan to look at it later, but at the time it was quicker to just ask. >> You're right, that's much better. I've now written a new version that >> does away with the "_second" function. The caller still has to be >> aware of the ring size limitation, but that's hard to avoid without >> making the interface hairier. > > Say, is that wheel your own invention? It was proposed by Roman Bednarek in <[EMAIL PROTECTED]>. Anyway, why the unfriendliness? Again, sorry about not having had the time to study a large program like Info-ZIP. The LFS patch I'm working on is still in its infancy, and there is a lot of room for improvements.
