Hrvoje Niksic wrote:
> One reason I was wary of adding the quotes was
> that the message is already quite long, and it interpolates three
> strings! I'm now changing it to:
>
>     "%s: %s: Invalid boolean `%s'; use on, off, always, or
> never.\n"
>
> That way we both avoid the "use always" trap and move the more
> useful values ("on" and "off") to the front.

Hmm, to avoid a line wrap at an unwanted place, one could include a 
"\n" before "use".  This would also highlight better the misspelled 
boolean, being then at the end of a line.

Sorry for nagging, but quoting the misspelled parameter and not 
quoting the suggested alternatives somehow doesn't square.

(And for symmetry: when using a semicolon here, the other "Invalid 
boolean" message should use it too.)

Benno

Reply via email to