[
https://issues.apache.org/jira/browse/WHIRR-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12882436#action_12882436
]
Tom White commented on WHIRR-27:
--------------------------------
Looks good. Thanks for writing this! Here are a few comments:
* Rather than waiting for 5 seconds, is there any way to poll the service to
see if it's up?
* In the test() method can we assert that the describe_keyspaces() call returns
something sane?
* The getSeeds() method seems a bit magic. It might be a candidate for a unit
test, or at least some documentation to say what it's doing and why.
* We could factor out some of the common code between this and the other
services, but that could be another JIRA.
* Nit: in pom.xml the services should probably be in alphabetical order.
> Add Cassandra service
> ---------------------
>
> Key: WHIRR-27
> URL: https://issues.apache.org/jira/browse/WHIRR-27
> Project: Whirr
> Issue Type: New Feature
> Components: core
> Reporter: Johan Oskarsson
> Assignee: Johan Oskarsson
> Fix For: 0.1.0
>
> Attachments: WHIRR-27.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
