[
https://issues.apache.org/jira/browse/WHIRR-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917365#action_12917365
]
Tom White commented on WHIRR-109:
---------------------------------
Thanks for the patch - overall it looks good.
* KeyPair is only needed for tests so it could be in the test tree (we probably
shouldn't expose it as a part of the public API).
* Instead of the System.err.println, a log statement would be better (see
WHIRR-106).
> Unit tests fail if there is no private key found at ~/.ssh/id_rsa
> ------------------------------------------------------------------
>
> Key: WHIRR-109
> URL: https://issues.apache.org/jira/browse/WHIRR-109
> Project: Whirr
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Adrian Cole
> Fix For: 0.2.0
>
> Attachments: WHIRR-109.patch
>
>
> We should generate a key for the test.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
