[ 
https://issues.apache.org/jira/browse/WHIRR-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917713#action_12917713
 ] 

Patrick Hunt commented on WHIRR-106:
------------------------------------

+1, lgtm, tests pass and output from cli is more informative.

> improve logging in whirr cli
> ----------------------------
>
>                 Key: WHIRR-106
>                 URL: https://issues.apache.org/jira/browse/WHIRR-106
>             Project: Whirr
>          Issue Type: Bug
>          Components: cli
>    Affects Versions: 0.1.0
>            Reporter: Patrick Hunt
>            Assignee: Tom White
>             Fix For: 0.2.0
>
>         Attachments: log4j.properties, WHIRR-106.patch, WHIRR-106.patch, 
> WHIRR-106.patch
>
>
> I believe there are two issues here:
> 1) services are not logging anything 
> 2) logging output does not seem to be setup correctly
> for 1) we should add info level (at least) messages to the service 
> implementations to indicate progress
> for 2) we should include a default log4j.properties (or xml) in the shaded 
> jar which has sane defaults (see attachment for an example I whipped up and 
> am using myself)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to