[
https://issues.apache.org/jira/browse/WHIRR-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12973794#action_12973794
]
Tom White commented on WHIRR-25:
--------------------------------
This looks great so far. A few quick, minor comments:
* Setting port numbers is being discussed in WHIRR-168. You might look there
and WHIRR-55 for naming conventions that are compatible with the approaches
being taken in those JIRAs.
* DnsUtil is in core now so you can use that rather than a copy.
* Can we share code between HadoopProxy and HBase proxy? They seem to be almost
the same.
* Nit: In BasicServerClusterActionHandler make the instance variables final?
> Add HBase service
> -----------------
>
> Key: WHIRR-25
> URL: https://issues.apache.org/jira/browse/WHIRR-25
> Project: Whirr
> Issue Type: New Feature
> Reporter: Tom White
> Fix For: 0.3.0
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
