[
https://issues.apache.org/jira/browse/WHIRR-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983024#action_12983024
]
Tom White commented on WHIRR-167:
---------------------------------
+1 This is looking good.
* The code is swallowing NumberFormatExceptions in ClusterSpec, which is the
right thing to do, but should have a comment, or a log statement.
* The cases for NumberFormatException would benefit from unit tests.
* Is ClusterSpec#parse(String... strings) still used? If not then we should
remove it.
* Please add some documentation for the new properties to
src/site/confluence/configuration-guide.confluence.
* Running "mvn checkstyle:checkstyle apache-rat:check" seems to produce some
warnings. Can you fix these please.
Thanks for running the integration tests.
> the HBase test failed for some other reasons
Yes, this is being tracked in WHIRR-201.
> kind of two phase argument parsing
I just meant that you'd have to parse the arguments once to pick up the
templates (probably not using JOpt Simple), then again with a new options
parser constructed with knowledge of the possible instance templates. But the
current way is fine.
> Improve bootstrapping and configuration to be able to isolate and repair or
> evict failing nodes on EC2
> ------------------------------------------------------------------------------------------------------
>
> Key: WHIRR-167
> URL: https://issues.apache.org/jira/browse/WHIRR-167
> Project: Whirr
> Issue Type: Improvement
> Environment: Amazon EC2
> Reporter: Tibor Kiss
> Assignee: Tibor Kiss
> Attachments: whirr-167-1.patch, whirr-167-2.patch, whirr-167-3.patch,
> whirr-integrationtest.tar.gz, whirr.log
>
>
> Actually it is very unstable the cluster startup process on Amazon EC2
> instances. How the number of nodes to be started up is increasing the startup
> process it fails more often. But sometimes even 2-3 nodes startup process
> fails. We don't know how many number of instance startup is going on at the
> same time at Amazon side when it fails or when it successfully starting up.
> The only think I see is that when I am starting around 10 nodes, the
> statistics of failing nodes are higher then with smaller number of nodes and
> is not direct proportional with the number of nodes, looks like it is
> exponentialy higher probability to fail some nodes.
> Lookint into BootstrapCluterAction.java, there is a note "// TODO: Check for
> RunNodesException and don't bail out if only a few " which indicated the
> current unreliable startup process. So we should improve it.
> We could add a "max percent failure" property (per instance template), so
> that if the number failures exceeded this value the whole cluster fails to
> launch and is shutdown. For the master node the value would be 100%, but for
> datanodes it would be more like 75%. (Tom White also mentioned in an email).
> Let's discuss if there are any other requirements to this improvement.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
