[
https://issues.apache.org/jira/browse/WHIRR-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004973#comment-13004973
]
Kirk True edited comment on WHIRR-237 at 3/10/11 5:42 AM:
----------------------------------------------------------
Uploaded version 3 of the code. This intentionally removes the Voldemort client
cluster as it's probably too specific to my personal use case.
* You don't need VoldemortClientService and VoldemortService since everything
is role based now.
Done.
* Change "voldemortclient" to "voldemort-client" by analogy with "hbase-master"
etc.
Done, indirectly.
* Change "whirr.voldemort-tar-url" to "whirr.voldemort.tarball.url" for
consistency with other services, like HBase. There are other properties that
should be changed too, and you might consider putting them in a constants class
(like HBaseConstants) to avoid duplication.
Done.
* There's a spurious reference to Cassandra in pom.xml.
Done.
* There are some tabs and inconsistent indentation (should be 2 spaces) in
places.
Done, _hopefully_. Is there a tool to check this?
* Try running "mvn checkstyle:checkstyle apache-rat:check" to test for style
and licensing compliance.
Done. Shell scripts have been updated with license.
was (Author: kirktrue):
* You don't need VoldemortClientService and VoldemortService since
everything is role based now.
Done.
* Change "voldemortclient" to "voldemort-client" by analogy with "hbase-master"
etc.
Voldemort client has been removed due to it being too specific to my personal
needs.
* Change "whirr.voldemort-tar-url" to "whirr.voldemort.tarball.url" for
consistency with other services, like HBase. There are other properties that
should be changed too, and you might consider putting them in a constants class
(like HBaseConstants) to avoid duplication.
Done.
* There's a spurious reference to Cassandra in pom.xml.
Copy-and-paste error :)
Done.
* There are some tabs and inconsistent indentation (should be 2 spaces) in
places.
This _should_ be fixed. Is there a tool to check this?
* Try running "mvn checkstyle:checkstyle apache-rat:check" to test for style
and licensing compliance.
Done. Shell scripts have been updated with license.
> Add Voldemort as a service
> --------------------------
>
> Key: WHIRR-237
> URL: https://issues.apache.org/jira/browse/WHIRR-237
> Project: Whirr
> Issue Type: New Feature
> Components: core
> Reporter: Roshan Sumbaly
> Priority: Minor
> Attachments: WHIRR-237.v1.patch, WHIRR-237.v2.patch,
> WHIRR-237.v3.patch, linkedin-voldemort-0.90.RC3.jar
>
>
> Add Voldemort as a service to Whirr. We have a first version (
> https://github.com/rsumbaly/whirr/tree/voldemort ) and another one with more
> features from Kirk ( https://github.com/kirktrue/whirr/tree/voldemort) - More
> description (
> https://groups.google.com/forum/?pli=1#!topic/project-voldemort/l6rb2X7YXEM )
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
