[ 
https://issues.apache.org/jira/browse/WHIRR-278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018957#comment-13018957
 ] 

Andrei Savu commented on WHIRR-278:
-----------------------------------

> Is it worth extracting Instance from Cluster for symmetry at the same time? 

Cluster.Instance is not that large and overall the Cluster class is small. I 
would postpone this change.

It would be great if we could commit this before WHIRR-245 because I want to 
add new options to ClusterSpec useful when creating the BlobStoreContext.

I can commit the patch now if it looks ready to you. 

> Refactor ClusterSpec and extract InstanceTemplate class
> -------------------------------------------------------
>
>                 Key: WHIRR-278
>                 URL: https://issues.apache.org/jira/browse/WHIRR-278
>             Project: Whirr
>          Issue Type: Improvement
>            Reporter: Andrei Savu
>            Assignee: Andrei Savu
>             Fix For: 0.5.0
>
>         Attachments: WHIRR-278.patch
>
>
> The file containing the ClusterSpec class is getting to large. I suggest we 
> should refactor the code to remove duplication and extract the 
> InstanceTemplate class. I also think it's a good idea to remove code that was 
> deprecated in 0.4.0. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to