[ 
https://issues.apache.org/jira/browse/WHIRR-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022364#comment-13022364
 ] 

Patrick Hunt commented on WHIRR-94:
-----------------------------------

Looks good, a few suggestions.

1) you should check the exit code when running the zk-* scripts to verify 
whether they were successful or failed.

2) this jira says benchmark, if you want to do that then you probably should 
use zk-latencies (use the zk-smoketest for a smoketest). You will probably also 
want to warm up the server prior to running a test that's purporting to be a 
benchmark.

it's unfortunate that the script downloads from github, not sure if there's a 
way to fix that though.

> Add a benchmark for ZooKeeper clusters
> --------------------------------------
>
>                 Key: WHIRR-94
>                 URL: https://issues.apache.org/jira/browse/WHIRR-94
>             Project: Whirr
>          Issue Type: Test
>          Components: service/zookeeper
>            Reporter: Tom White
>            Assignee: Andrei Savu
>         Attachments: WHIRR-94.patch
>
>
> It would be good to have a benchmark to run against ZooKeeper clusters. Is 
> there a standard one included in ZooKeeper?
> It might be useful to have a way of running Smoketest 
> (http://github.com/phunt/zk-smoketest) easily too, from a test for example.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to