[
https://issues.apache.org/jira/browse/WHIRR-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032788#comment-13032788
]
Adrian Cole edited comment on WHIRR-61 at 5/13/11 1:27 AM:
-----------------------------------------------------------
here's a patch that decouples all the classes from the compute service cache,
and makes a nice threadsafe one.
Side note:
I've fixed a few broken windows (ex. unused imports & fields, missing generic
type params, etc) and included these in the same patch intentionally.
While it is a minor pain to glance at these small fixes while also looking at
the core changes, I strongly believe it is for the better. We should make it
easier to fix broken windows then to break them. Jailing window-fixing into
separate jiras will surely demotivate those of us who like keep the project
clean. Being flexible about allowing trivial fixes in patches will encourage
us.
was (Author: [email protected]):
here's a patch that decouples all the classes from the compute service
cache, and makes a nice immutable one.
Side note:
I've fixed a few broken windows (ex. unused imports & fields, missing generic
type params, etc) and included these in the same patch intentionally.
While it is a minor pain to glance at these small fixes while also looking at
the core changes, I strongly believe it is for the better. We should make it
easier to fix broken windows then to break them. Jailing window-fixing into
separate jiras will surely demotivate those of us who like keep the project
clean. Being flexible about allowing trivial fixes in patches will encourage
us.
> make more efficient use of ComputeServiceContext
> ------------------------------------------------
>
> Key: WHIRR-61
> URL: https://issues.apache.org/jira/browse/WHIRR-61
> Project: Whirr
> Issue Type: Improvement
> Reporter: Adrian Cole
> Assignee: Andrei Savu
> Fix For: 0.5.0
>
> Attachments: WHIRR-61.patch, WHIRR-61.patch, WHIRR-61.patch,
> WHIRR-61.patch, WHIRR-61.patch
>
>
> The ComputeService object is thread-safe, and better off shared inside the
> Service object. Regardless, it must be closed in order to release
> threadpools.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
